New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate adapter version # at buildtime #43

Closed

DelusionalOptimist opened this issue Sep 28, 2021 · 0 comments · Fixed by #48

Assignees

Labels

help wanted kind/chore

Contributor

DelusionalOptimist commented Sep 28, 2021

Current Behavior
The adapter doesn't get build version assigned at build time.

Desired Behavior

Add build args and linker flags to Dockerfile. For example see this: https://github.com/meshery/meshery/blob/8f8df6a5f0d1dc357618abdc9c45c77f1e579df4/Dockerfile#L3-L5
Update the release and build workflow. For example see this: https://github.com/meshery/meshery/blob/8f8df6a5f0d1dc357618abdc9c45c77f1e579df4/.github/workflows/build-and-release.yml#L26

Contributor Resources

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
See Meshery site designs in this Figma designfile. Fill-in the Layer5 Community Member Form and join the Layer5 Community Slack for access.

The text was updated successfully, but these errors were encountered:

DelusionalOptimist added kind/chore help wanted labels

DelusionalOptimist mentioned this issue

Add adapter version at build time meshery/meshery-nsm#128

Closed

sayantan1413 mentioned this issue

[Chore] Support for adaptor version at build time #48

Merged

1 task

sayantan1413 self-assigned this

leecalcote closed this as completed in #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment