Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Support multi-platform Docker images #145

Closed
Zanda256 opened this issue Mar 31, 2022 · 3 comments
Closed

[CI] Support multi-platform Docker images #145

Zanda256 opened this issue Mar 31, 2022 · 3 comments
Assignees
Labels
area/ci Continuous integration | Build and release help wanted Extra attention is needed

Comments

@Zanda256
Copy link

Desired Behavior

Meshery users, particularly those running Docker Desktop can benefit from multi-platform images of Meshery Server.

Implementation

Refactor existing stable and edge build and release workflows to use docker-build-push actions. See https://github.com/meshery/meshery/blob/master/.github/workflows/build-and-release-dde.yml as an example.

Be aware of local binaries and their needs:

  1. layer5/kubeopenapi-json

Acceptance Tests

  1. platform: linux/amd64,linux/arm64 should both be supported.

Mockups


Contributor Guides and Resources

@Zanda256 Zanda256 added help wanted Extra attention is needed area/ci Continuous integration | Build and release labels Mar 31, 2022
@VaibhavMalik4187
Copy link
Contributor

@leecalcote I'd like to work on this issue

@leecalcote
Copy link
Member

Good deal... although, I believe this has already been completed - https://github.com/meshery/meshery-nsm/blob/master/.github/workflows/multi-platform.yaml

@VaibhavMalik4187
Copy link
Contributor

VaibhavMalik4187 commented Aug 10, 2023

Good deal... although, I believe this has already been completed - https://github.com/meshery/meshery-nsm/blob/master/.github/workflows/multi-platform.yaml

Oops, I was only reading the build-and-release.yml file and thus, completely missed it. Thanks for the heads up.

So, we should close this issue then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous integration | Build and release help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants