Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flickering in default dark theme #1451

Closed
vishalvivekm opened this issue Oct 4, 2023 · 7 comments · Fixed by #1455
Closed

Flickering in default dark theme #1451

vishalvivekm opened this issue Oct 4, 2023 · 7 comments · Fixed by #1455
Assignees
Labels
hacktoberfest Happy contributing! help wanted Extra attention is needed kind/bug Something isn't working

Comments

@vishalvivekm
Copy link
Member

Description

There's flickering in default dark theme on reload or while navigating to other pages of site.

Meshery.The.Kubernetes.and.Cloud.Native.Manager.-.an.extensible.developer.platform._.Meshery.-.Google.Chrome.2023-10-04.19-05-51.mp4

Expected Behavior

The light theme doesn't have any flickering issue and the same is desired for the dark-theme too.

Screenshots

Enviroment:

  • OS: Mac Linux Windows
  • Browser: Chrome Safari Firefox
  • Version:
  • Device: Desktop Mobile

Contributor Guides and Handbook

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

@vishalvivekm vishalvivekm added kind/bug Something isn't working help wanted Extra attention is needed hacktoberfest Happy contributing! labels Oct 4, 2023
@coder12git
Copy link
Contributor

@vishalvivekm I want to work on this. So, just for surity, I want to ask that issue is mainly that the site has default dark theme but on navigating to different pages of site, it's showing light theme first and after few seconds it's coming to it's default dark mode, and this is same for reloading the site. Am I right?

@ArpitShukla3
Copy link

i am looking into it

@coder12git
Copy link
Contributor

i am looking into it

Did someone assign you, just asking because it's not showing here, that's why I comment?

@ArpitShukla3
Copy link

No, but i am trying to understand code flow

@ArpitShukla3
Copy link

@coder12git could you help me in getting started with its code flow

@vishalvivekm
Copy link
Member Author

@vishalvivekm I want to work on this. So, just for surity, I want to ask that issue is mainly that the site has default dark theme but on navigating to different pages of site, it's showing light theme first and after few seconds it's coming to it's default dark mode, and this is same for reloading the site. Am I right?

Right @coder12git.
Will be following FCFS while assigning // @coder12git @ArpitShukla3

could you help me in getting started with its code flow

Great call out by @ArpitShukla3, :)

@coder12git
Copy link
Contributor

@coder12git could you help me in getting started with its code flow

Sure, you can message me on slack ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Happy contributing! help wanted Extra attention is needed kind/bug Something isn't working
Projects
None yet
3 participants