Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install: Incorporate helm package creation into Meshery release workflow #91

Closed
leecalcote opened this issue Feb 10, 2020 · 5 comments
Closed
Labels
issue/stale Issue has not had any activity for an extended period of time kind/enhancement New feature or request

Comments

@leecalcote
Copy link
Member

Current Behavior
Given that the source for Meshery's helm charts in is the Meshery repo, instead of storing the compressed version of the charts in this repo (meshery.io) as a charts "release", can we consider incorporating the tar.gz creation of these charts to our GitHub Actions workflow in Meshery?

We would include the tar.gz creation part of the tagged workflow (the workflow that is enacted when a release tag is present). We could either have goreleaser tar.gz the charts or have a script executed to tar.gz the charts and make that tar.gz available alongside the rest of the Meshery release artifacts here - https://github.com/layer5io/meshery/releases

In this way, the Meshery helm chart is treated as another release artifact that is created each time we cut a new Meshery release.

@leecalcote leecalcote added the kind/enhancement New feature or request label Feb 10, 2020
@leecalcote
Copy link
Member Author

@Aisuko identified a possible start to the solution for this issue - #93 (comment)

@leecalcote
Copy link
Member Author

leecalcote commented Sep 9, 2020

@Aisuko, @mgfeller, what are your thoughts here? Is this something needed / worth pursuing?

Note the chart version on https://hub.helm.sh/charts/meshery/meshery.
Note that this repo is use to host the chart: https://github.com/layer5io/meshery.io/tree/master/charts

@Aisuko
Copy link
Member

Aisuko commented Sep 9, 2020

@Aisuko, @mgfeller, what are your thoughts here? Is this something needed / worth pursuing?

Note the chart version on https://hub.helm.sh/charts/meshery/meshery.
Note that this repo is use to host the chart: https://github.com/layer5io/meshery.io/tree/master/charts

I saw the image tag in meshery Helm chart always set as the latest. since we change the CI scripts to build three version of the image like the latest git tag as tag etc. So, every time the user deploy meshery with helm chart will use the tag latest image of meshery. So, I believe we do not need to add the Helm chart into the release page

@stale
Copy link

stale bot commented Jun 28, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Jun 28, 2021
@leecalcote
Copy link
Member Author

Finally: DONE!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/stale Issue has not had any activity for an extended period of time kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants