Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Models] Relationship: Need Edge support for all Annotation Components #10278

Closed
leecalcote opened this issue Feb 13, 2024 · 4 comments
Closed
Labels
area/devops area/models Models, Components, Relationships related changes good first issue Good for newcomers help wanted Extra attention is needed issue/stale Issue has not had any activity for an extended period of time

Comments

@leecalcote
Copy link
Member

Current Situation

The meshery-flowchart model is missing relationship definitions for its annotation components.

Proposed Change

Each component should have the capability to form an annotation edge.


Contributor Guides and Handbook

Contributing to Meshery Models

!! See https://docs.meshery.io/project/contributing/contributing-models

Instructions for Models

Forthcoming

Instructions for Components

While the default shape for new components is a circle, each component should be considered for its best-fit shape.

  1. Review and familiarize with the available set of predefined relationship types. Refer the Cytoscape node types for a list of possible shapes.
  2. Propose a specific shape, best-suited to visually represent the Component. Example - Deployment as a pentagon.
  3. Proposee a specific icon, best-suited to visually represent the Component. Example - DaemonSet as a skull icon.

Instructions for Relationships

  1. Identify the relationship and any specific constraints to be enforced between the two specific components, their models or potentially other components, models, or environmental considerations.
  2. Propose a specific visual representation for the relationship. See example on Modeling Relationships.
  3. Prospose the appropriate relationship type, using one of the predefined set of relationship types or suggest a new relationship where an existing type does not fit.
  4. Create a Relationship Definition (yaml).
  5. Create a policy for evaluation of the relationship (rego).

Instructions for Policies

  1. Forthcoming
@leecalcote leecalcote added help wanted Extra attention is needed good first issue Good for newcomers area/devops area/models Models, Components, Relationships related changes labels Feb 13, 2024
@SammyBloom
Copy link

I am interested in this issue

@MeenuyD
Copy link
Contributor

MeenuyD commented Feb 14, 2024

Hello @leecalcote I would like to work on this issue can you please assign it to me.

Copy link

stale bot commented May 5, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label May 5, 2024
Copy link

stale bot commented May 17, 2024

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this as completed May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devops area/models Models, Components, Relationships related changes good first issue Good for newcomers help wanted Extra attention is needed issue/stale Issue has not had any activity for an extended period of time
Projects
None yet
Development

No branches or pull requests

3 participants