Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Introduce golang-ci-lint for our CI Testing. #1050

Closed
kushthedude opened this issue May 24, 2020 · 4 comments · Fixed by #1460
Closed

[CI] Introduce golang-ci-lint for our CI Testing. #1050

kushthedude opened this issue May 24, 2020 · 4 comments · Fixed by #1460
Assignees
@kushthedude
Labels
area/ci Continuous Integration issue/willfix This issue will be worked on kind/enhancement Improvement in current feature

Comments

@kushthedude
Copy link
Contributor

Current Behavior

Right now, we are using 4 different actions for similar sort of golang actions. Moreover, adding to it we have 4 different cache jobs for each action which totals to 8 GitHub Actions which not only increases the CI time but also is a waste of resources.

Desired Behavior

Replace the current linter & error checker with golang-ci-lint.

Resources

https://github.com/golangci/golangci-lint

Alternatives / Additional Context

Let me know if anyone is interested in implementing it or else I will go forward with this.
@kushthedude kushthedude added kind/enhancement Improvement in current feature area/ci Continuous Integration labels May 24, 2020
@kushthedude
Copy link
Contributor Author

/cc @nitishm

@kushthedude kushthedude self-assigned this May 27, 2020
@leecalcote leecalcote changed the title Introduce golang-ci-lint for our CI Testing. [CI] Introduce golang-ci-lint for our CI Testing. Jun 20, 2020
@tharun208
Copy link

Also, better suggestion is to also add a make command to run golangci-lint as a developer practice. Before, pushing the changes.

@leecalcote
Copy link
Member

Great suggestion, @tharun208. 👍

@leecalcote leecalcote added the issue/willfix This issue will be worked on label Jul 5, 2020
@tharun208
Copy link

I like to work on this

@leecalcote leecalcote assigned tharun208 and unassigned kushthedude Jul 22, 2020
@kushthedude kushthedude assigned kushthedude and unassigned tharun208 Aug 25, 2020
@kushthedude kushthedude mentioned this issue Aug 25, 2020
Merged
@mgfeller mgfeller mentioned this issue Aug 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kushthedude kushthedude

Labels
area/ci Continuous Integration issue/willfix This issue will be worked on kind/enhancement Improvement in current feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: migrate to golangci-lint
3 participants
@leecalcote @tharun208 @kushthedude