Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Server] Not returning error code moniker in events, only numeric error code. #10761

Open
leecalcote opened this issue Apr 23, 2024 · 2 comments · May be fixed by #10958
Open

[Server] Not returning error code moniker in events, only numeric error code. #10761

leecalcote opened this issue Apr 23, 2024 · 2 comments · May be fixed by #10958
Assignees
Labels
component/server issue/willfix This issue will be worked on kind/bug Something isn't working language/go Issues or pull requests that use Golang

Comments

@leecalcote
Copy link
Member

leecalcote commented Apr 23, 2024

Current Behavior

Example error:
Screenshot 2024-04-23 at 10 32 32 AM

Hyperlinks to https://docs.meshery.io/reference/error-codes#meshery-server-1073, which only includes the sub-system ("meshery-server") and not the moniker ("ErrCompConfigPairsCode").

image

Expected Behavior

Moniker should be included in addition to component.

Environment

  • Meshery Server Version: stable-v0.7.46

Contributor Guides and Handbook

@leecalcote leecalcote added kind/bug Something isn't working issue/willfix This issue will be worked on language/go Issues or pull requests that use Golang component/server labels Apr 23, 2024
@EleisonC
Copy link
Contributor

EleisonC commented May 6, 2024

Hey @leecalcote could I be assigned this task?

@EleisonC
Copy link
Contributor

EleisonC commented May 9, 2024

Hey @leecalcote, I managed to reproduce the error mentioned earlier. Could you provide some additional context regarding the expected behaviour? Specifically, if the value for the code changes from Code: meshery-server-1073 to either Code: meshery-server-1073(ErrCompConfigPairsCode) or Code: ErrCompConfigPairsCode-1073, what implications or changes in behaviour should we anticipate?

@EleisonC EleisonC linked a pull request May 14, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/server issue/willfix This issue will be worked on kind/bug Something isn't working language/go Issues or pull requests that use Golang
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants