Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Extensions] Confirmation Model upon deleting designs #10783

Open
leecalcote opened this issue Apr 25, 2024 · 6 comments
Open

[Extensions] Confirmation Model upon deleting designs #10783

leecalcote opened this issue Apr 25, 2024 · 6 comments
Labels
component/extensions Issues related to extension points framework/react issue/willfix This issue will be worked on kind/enhancement Improvement in current feature

Comments

@leecalcote
Copy link
Member

Current Behavior

In the MeshMap Designer extension, users might accidentally delete their designs without confirmation.

Desired Behavior

Screenshot 2024-04-25 at 7 57 41鈥疉M

Implementation

Acceptance Tests

Mockups


Contributor Guides and Handbook

@leecalcote leecalcote added kind/enhancement Improvement in current feature component/extensions Issues related to extension points issue/willfix This issue will be worked on framework/react labels Apr 25, 2024
@RafaelJohn9
Copy link

@leecalcote I would like to work on this issue

@surajgjadhav
Copy link

surajgjadhav commented May 24, 2024

Hi,
I have added comment on Figma to add design on this scenario, then maybe we can continue working
or can we design modal directly by referring to existing Modals.
@leecalcote Please Suggest
Thanks

@leecalcote
Copy link
Member Author

@Rexford74

@Rexford74
Copy link

Rexford74 commented May 24, 2024

Thank you for notifying me, @leecalcote.
The confirmation modal will suffice in this case. This is a link to what the modal should look like and this is the behaviour that can accompany the interaction.
The overlay background added has the hex code #000d12 at 50% opacity. When the trigger is clicked, the modal dissolves onto the page at a speed of 300ms with an 'Ease out' transition. Let me know if you'd need any further information to complete this task, @surajgjadhav.

Have you been assigned the task yet, @surajgjadhav or are you just making enquiries?

@surajgjadhav
Copy link

Hi @Rexford74 ,
Thanks for confirming. No it's not yet assigned to me.
one more doubt:
do we need to develop it in sisten repo first and then use it in ui
or we can create it directly in ui ?
Please suggest
thanks

@Rexford74
Copy link

No, Suraj. It won't be necessary to create the modal from scratch. I understand that there is already one created in Sistent. Use that one instead and implement the necessary changes there. Do let me know if you have any more questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/extensions Issues related to extension points framework/react issue/willfix This issue will be worked on kind/enhancement Improvement in current feature
Projects
None yet
Development

No branches or pull requests

4 participants