Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mesheryctl] Confirm that helm charts, not k8s manifests are used for Meshery install #10926

Open
leecalcote opened this issue May 10, 2024 · 3 comments
Open

[mesheryctl] Confirm that helm charts, not k8s manifests are used for Meshery install #10926

leecalcote opened this issue May 10, 2024 · 3 comments
Assignees
@Aryakoste
Labels
component/mesheryctl CLI for Meshery go Pull requests that update Go code help wanted Extra attention is needed issue/willfix This issue will be worked on language/go Issues or pull requests that use Golang

Comments

@leecalcote
Copy link
Member

See mesheryctl Command Tracker for current status of commands.

Current Behavior

Is this old code, unused, and can be removed? https://github.com/meshery/meshery/blob/master/mesheryctl/pkg/utils/platform.go#L127

Contributor Resources
@leecalcote leecalcote added kind/enhancement Improvement in current feature help wanted Extra attention is needed component/mesheryctl CLI for Meshery language/go Issues or pull requests that use Golang go Pull requests that update Go code labels May 10, 2024
@github-actions GitHub Actions
Copy link

This issue has been labeled with 'component/mesheryctl'. Note that after making changes you need to update it in the mesheryctl command tracker spreadsheet.

        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@leecalcote leecalcote added the issue/willfix This issue will be worked on label May 10, 2024
@Aryakoste
Copy link
Contributor

Hello @leecalcote i would like to work on this issue. We just have to check if the above given code is used in meshery install and if not remove it right ?.

@leecalcote
Copy link
Member Author

Thank you very much, @Aryakoste. Yes, sir, that’s right.

@leecalcote leecalcote removed the kind/enhancement Improvement in current feature label May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aryakoste Aryakoste

Labels
component/mesheryctl CLI for Meshery go Pull requests that update Go code help wanted Extra attention is needed issue/willfix This issue will be worked on language/go Issues or pull requests that use Golang
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leecalcote @Aryakoste