Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI]: Unexpected error popping up for 'View SMI Conformance Results' #1631

Closed
Nikhil-Ladha opened this issue Oct 2, 2020 · 5 comments · Fixed by #1665
Closed

[UI]: Unexpected error popping up for 'View SMI Conformance Results' #1631

Nikhil-Ladha opened this issue Oct 2, 2020 · 5 comments · Fixed by #1665
Assignees
Labels
hacktoberfest Happy contributing! kind/bug Something isn't working

Comments

@Nikhil-Ladha
Copy link
Member

Description

On navigating to any of the adapter page and without performing any SMI Conformance test, on clicking the View SMI Conformance Result chip a modal opens showing the empty table. But, just within a minute an error snackbar pops consuming the whole page (see in the screenshot below)

Expected Behavior

The snackbar should not come up even if no tests have been run.

Screenshots

Screenshot from 2020-10-02 16-27-42

Environment:

  • OS: [e.g. Ubuntu]: Fedora 32
  • Browser: [e.g. Chrome, Safari] Chrome
  • Version: [e.g. 22]
  • Device: [e.g. laptop, iPhone 8] Laptop

[Optional] To Reproduce
Steps to reproduce the behavior:

  1. Go to '...' Adapters page
  2. Click on '....' View SMI Conformance Results chip
  3. See error snackbar pop up within few moments

[Optional] Additional Context

@Nikhil-Ladha Nikhil-Ladha added kind/bug Something isn't working hacktoberfest Happy contributing! labels Oct 2, 2020
@Nikhil-Ladha
Copy link
Member Author

@dhruv0000 , @kumarabd , @leecalcote ^^

@kumarabd kumarabd self-assigned this Oct 2, 2020
@ghost
Copy link

ghost commented Oct 2, 2020

What could be the cause of the error? I would like to reproduce the error but my system's bad right now😫😫

@kumarabd
Copy link
Contributor

kumarabd commented Oct 3, 2020

@Nikhil-Ladha Which service mesh gave u this?

@Nikhil-Ladha
Copy link
Member Author

All of them

@Nikhil-Ladha Which service mesh gave u this?

@dhruv0000 dhruv0000 self-assigned this Oct 8, 2020
@dhruv0000
Copy link
Member

Seems like problem is logging in with meshery provider for the movement, since we have not implemented the provider database endpoint for fetching SMI results.
Since we have two visual conformation of data not getting fetched (the table itself and the snackbar ), you are right @Nikhil-Ladha , There is no need of the snackbar to be shown in case of data not getting fetched since the table already shows "Sorry, no matching records found" in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Happy contributing! kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants