Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] golangci-lint tests are broken #6385

Closed
XDRAGON2002 opened this issue Oct 13, 2022 · 2 comments · Fixed by #6484
Closed

[CI] golangci-lint tests are broken #6385

XDRAGON2002 opened this issue Oct 13, 2022 · 2 comments · Fixed by #6484
Assignees
Labels
area/ci Continuous Integration component/mesheryctl CLI for Meshery

Comments

@XDRAGON2002
Copy link
Member

Current Behavior

Due to version update to go 1.19, golangci-lint is facing compatibility issues as they too have recently added support for go 1.19 and still a lot of bugs remain.
Example logs: this and this.

Desired Behavior

The golangci-lint tests should be working properly.

Implementation

Wait for compatibility issues for go 1.19 to be resolved from upstream, see golangci/golangci-lint#2374 and golangci/golangci-lint#3107.


Contributor Guides and Handbook

@XDRAGON2002 XDRAGON2002 added the area/ci Continuous Integration label Oct 13, 2022
@welcome
Copy link

welcome bot commented Oct 13, 2022

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide, engage in the discussion forum, and be sure to join the community Slack.

@github-actions
Copy link

This issue has been labeled with 'component/mesheryctl'. Note that after making changes you need to update it in the mesheryctl command tracker spreadsheet.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous Integration component/mesheryctl CLI for Meshery
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants