Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Designer Configurator should use Meshmodel component. #7356

Closed
harkiratsm opened this issue Mar 15, 2023 · 12 comments
Closed

[UI] Designer Configurator should use Meshmodel component. #7356

harkiratsm opened this issue Mar 15, 2023 · 12 comments
Assignees
Labels
area/ux User experience component/ui User Interface framework/react help wanted Extra attention is needed kind/enhancement Improvement in current feature language/javascript Issues or pull requests that use Javascript or React

Comments

@harkiratsm
Copy link
Member

harkiratsm commented Mar 15, 2023

Current Behavior

Currently, the designer configurator is using oam interface.

Desired Behavior

Since we had moved forward with meshmodel, we need all the categories and components in place for that in the design configurator itself.

Implementation

  1. Under the Meshery API endpoints doc, you can find meshmodel endpoints.

  2. Visit the meshmap playground to find out what you're working on.


Contributor Guides and Handbook

@harkiratsm harkiratsm added kind/enhancement Improvement in current feature language/javascript Issues or pull requests that use Javascript or React component/ui User Interface framework/react area/ux User experience labels Mar 15, 2023
@github-actions
Copy link

This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@Abhishek-kumar09
Copy link
Member

Screenshot 2023-03-15 at 8 02 38 PM

Screenshot 2023-03-15 at 8 02 56 PM

Screenshot 2023-03-15 at 8 03 17 PM

Get list of All Models:
https://docs.meshery.io/reference/rest-apis#api-meshmodel-model-get-handle-get-request-for-getting-all-mesh

Get components from a certain Model:
https://docs.meshery.io/reference/rest-apis#api-meshmodel-model-model-component-get-handle-get-request-for

Get certain component from certain model
https://docs.meshery.io/reference/rest-apis#api-meshmodel-model-model-component-name-get-handle-get-request

All the rest API endpoints are available here
https://docs.meshery.io/reference/rest-apis

Its better suited to start from scratch then making the changes in the current functional components. The new component should suit well, because a lot of things has been changed that is not incorporated in the current UI.

@yash37158
Copy link
Member

LGTM, i can work on this issue @Abhishek-kumar09 @harkiratsm

@Abhishek-kumar09
Copy link
Member

Thanks for taking this issue, @yash37158 Let me know if you need any help here. You can always be vocal about it in slack or github issue thread.

@yash37158
Copy link
Member

Yeah sure

@yash37158
Copy link
Member

Hey @Abhishek-kumar09 do we have a separate folder for design patterns? where can I see the code for k8s?

@Abhishek-kumar09
Copy link
Member

Abhishek-kumar09 commented Mar 22, 2023

The data is loaded dynamically, and the the layout and its state management is being done in React.

Here are some files involved:

  1. https://github.com/meshery/meshery/blob/master/ui/components/MesheryPatterns.js
  2. https://github.com/meshery/meshery/blob/master/ui/components/configuratorComponents/patternConfigurator.js The UI due to which you're able to see the design-configurator
  3. The RJSF interface code is here, which is likely to be unchanged: https://github.com/meshery/meshery/tree/master/ui/components/MesheryMeshInterface

IMO, the point 2 will be the area where you can refer some things and it mostly requires a complete re-write.
Please let us know if you need some help or time.

@yash37158
Copy link
Member

I am unassigning myself from this issue, if this issue still persists would try to take up that in future @leecalcote @Abhishek-kumar09

@yash37158 yash37158 removed their assignment Mar 23, 2023
@leecalcote leecalcote added the help wanted Extra attention is needed label Mar 23, 2023
@leecalcote
Copy link
Member

@harkiratsm if no one else gets assigned today, then please self-assign this issue.

@harkiratsm
Copy link
Member Author

I am taking this on.

@harkiratsm harkiratsm self-assigned this Mar 24, 2023
@stale
Copy link

stale bot commented May 3, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label May 3, 2023
@aminoxix aminoxix removed the issue/stale Issue has not had any activity for an extended period of time label May 14, 2023
@harkiratsm
Copy link
Member Author

completed #7578

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ux User experience component/ui User Interface framework/react help wanted Extra attention is needed kind/enhancement Improvement in current feature language/javascript Issues or pull requests that use Javascript or React
Projects
None yet
Development

No branches or pull requests

5 participants