Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Make UI/UX consistent for Publishing catalog content. #7379

Closed
Revolyssup opened this issue Mar 22, 2023 · 11 comments
Closed

[UI] Make UI/UX consistent for Publishing catalog content. #7379

Revolyssup opened this issue Mar 22, 2023 · 11 comments
Assignees
Labels
component/ui User Interface framework/react issue/stale Issue has not had any activity for an extended period of time kind/enhancement Improvement in current feature language/javascript Issues or pull requests that use Javascript or React

Comments

@Revolyssup
Copy link
Contributor

Revolyssup commented Mar 22, 2023

Current Behavior

A publish button is available currently that sends a publish request for publishing content. But there are a lot of UI/UX inconsistencies

Desired Behavior

  1. Content like design have a visibility field set to Public Private and Published
  2. Currently both Public and Published are shown as Public, which shouldn't be the case.
  3. Have different UX for different visibility
    a. For public/private designs, have a publish button.
    b. For public/private designs which already have been requested to get published will result in an error. Handle the error gracefully with an error message describing that the request has been submitted and will be approved. And to prompt users to check their mail.
    c. For the already Published content, add an unpublish button for the owners and admins of the content to unpublish the catalog item.
  4. Change server to send 202 Accepted when a publish request is submitted.

Implementation

Acceptance Tests

Mockups


Contributor Guides and Handbook

@Revolyssup Revolyssup added kind/enhancement Improvement in current feature language/javascript Issues or pull requests that use Javascript or React component/ui User Interface framework/react labels Mar 22, 2023
@Revolyssup Revolyssup changed the title [UI] Add support for unpublishing/privatizing catalog content [UI] Add support for unpublishing/privatising catalog content Mar 22, 2023
@github-actions
Copy link

This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@Revolyssup Revolyssup changed the title [UI] Add support for unpublishing/privatising catalog content [UI] Make UI/UX consistent for Publishing catalog content. Mar 22, 2023
@thisiskaransgit
Copy link
Contributor

I am willing to work on this issue!

@Srinja333
Copy link

Can I work on this?

@thisiskaransgit
Copy link
Contributor

Hey @Revolyssup, with respect to the following point

Change server to send 202 Accepted when a publish request is submitted.

this is the file where I should be making changes right?

		if res.StatusCode != 200 {
			// failsafe for the case when a valid uuid v4 is not an id of any pattern (bad api call)
			return errors.Errorf("Response Status Code %d, possible invalid ID", res.StatusCode)

meshery/mesheryctl/internal/cli/root/pattern/view.go

if not, a little guidance on how to proceed with it will be helpful.

  • And other than that I've changed the snackbar dialog from "Design Published!" to "Design sent for review, check your email for further updates "

@Revolyssup
Copy link
Contributor Author

little guidance on how to proceed with it will be helpful.

Nope, this is mesheryctl. The change would be in Meshery cloud as well as Meshery server code. I will do that. Create another issue and assign it to me.

@stale
Copy link

stale bot commented May 6, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label May 6, 2023
@vishalvivekm vishalvivekm removed the issue/stale Issue has not had any activity for an extended period of time label May 15, 2023
@vishalvivekm
Copy link
Member

@thisiskaransgit what's the status on this issue? // @harkiratsm

@stale
Copy link

stale bot commented Jun 24, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Jun 24, 2023
@vishalvivekm vishalvivekm removed the issue/stale Issue has not had any activity for an extended period of time label Jun 24, 2023
@stale
Copy link

stale bot commented Sep 4, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Sep 4, 2023
@vishalvivekm vishalvivekm removed the issue/stale Issue has not had any activity for an extended period of time label Sep 4, 2023
@stale
Copy link

stale bot commented Oct 14, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Oct 14, 2023
@stale
Copy link

stale bot commented Oct 24, 2023

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this as completed Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui User Interface framework/react issue/stale Issue has not had any activity for an extended period of time kind/enhancement Improvement in current feature language/javascript Issues or pull requests that use Javascript or React
Projects
None yet
Development

No branches or pull requests

6 participants