Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Rows per page is not working in meshmodel tabs in settings #7971

Closed
Yashsharma1911 opened this issue Jun 28, 2023 · 7 comments · Fixed by #7988
Closed

[UI] Rows per page is not working in meshmodel tabs in settings #7971

Yashsharma1911 opened this issue Jun 28, 2023 · 7 comments · Fixed by #7988
Assignees
Labels
component/ui User Interface kind/bug Something isn't working

Comments

@Yashsharma1911
Copy link
Contributor

Current Behavior

In tabs Models, Components Rows per page is not working

Screen.Recording.2023-06-28.at.6.29.37.PM.mov

Expected Behavior

Screenshots/Logs

Environment

  • Host OS: Mac Linux Windows
  • Platform: Docker or Kubernetes
  • Meshery Server Version: stable-v
  • Meshery Client Version: stable-v

Contributor Guides and Handbook

@Yashsharma1911 Yashsharma1911 added kind/bug Something isn't working component/ui User Interface labels Jun 28, 2023
@github-actions
Copy link

This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@HarshDobariya79
Copy link
Member

I would like to work on this issue, can I get assigned, please?

@Meyazhagan
Copy link
Member

@HarshDobariya79 you got it!

@HarshDobariya79
Copy link
Member

@Yashsharma1911 @Meyazhagan
page size for all mesh model components APIs is hard coded to 25 from the back-end. So let's say user selects page size as 100, should we call the API multiple times (4 times in this case) or should we provide an optional argument in API itself for page size? or we can do something else. Please give your inputs.

@Meyazhagan
Copy link
Member

@HarshDobariya79 You can pass pagesize in query. ref:

// ```?pagesize={pagesize}``` Default pagesize is 25. To return all results: ```pagesize=all```

@HarshDobariya79
Copy link
Member

@HarshDobariya79 You can pass pagesize in query. ref:

// ```?pagesize={pagesize}``` Default pagesize is 25. To return all results: ```pagesize=all```

Oops I missed that. Thank you for pointing out.

@HarshDobariya79
Copy link
Member

HarshDobariya79 commented Jun 29, 2023

I'm not able to understand why we need to perform logical AND operation. Can anyone please assist?

data={resourcesDetail && resourcesDetail}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui User Interface kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants