-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change CustomToolbar.js
from class based component to functional component
#8565
Comments
Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Contributors' Welcome Guide, engage in the discussion forum, and be sure to join the community Slack. |
Hey @aabidsofi19 as we talked earlier can you assign me this issue? |
Fixed. |
Gentlemen, It is most excellent to see this work being done. 👏 |
I guess you have mistaken. The PR attached where is the previous one I am working on. Migrating the Notification system. I can see the CustomToolbar.js as a class component in the master branch. I am working on it and will raise a PR by today. Can you confirm please? @leecalcote |
@Rajdip019, oh, I assumed that the linked PR (merged) above was the fix for this issue. |
I retract my comment about the good work being done here. 😉 …and will wait to lodge that comment after is is actually done. 😆 |
Current Behavior
CustomToolbar.js
is a Class based componentDesired Behavior
CustomToolbar.js
as a functional react compoenntImplementation
Will convert the
CustomToolbar.js
to a modern functional component and will make the changes to incorporate those changes.Contributor Guides and Handbook
The text was updated successfully, but these errors were encountered: