Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CustomToolbar.js from class based component to functional component #8565

Closed
Rajdip019 opened this issue Aug 22, 2023 · 7 comments · Fixed by #8582
Closed

Change CustomToolbar.js from class based component to functional component #8565

Rajdip019 opened this issue Aug 22, 2023 · 7 comments · Fixed by #8582
Assignees
Labels
kind/enhancement Improvement in current feature

Comments

@Rajdip019
Copy link
Contributor

Current Behavior

CustomToolbar.js is a Class based component

Desired Behavior

CustomToolbar.js as a functional react compoennt

Implementation

Will convert the CustomToolbar.js to a modern functional component and will make the changes to incorporate those changes.


Contributor Guides and Handbook

@Rajdip019 Rajdip019 added the kind/enhancement Improvement in current feature label Aug 22, 2023
@welcome
Copy link

welcome bot commented Aug 22, 2023

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Contributors' Welcome Guide, engage in the discussion forum, and be sure to join the community Slack.

@Rajdip019
Copy link
Contributor Author

Hey @aabidsofi19 as we talked earlier can you assign me this issue?

@leecalcote
Copy link
Member

Fixed.

@leecalcote
Copy link
Member

Gentlemen,

It is most excellent to see this work being done. 👏

@Rajdip019
Copy link
Contributor Author

I guess you have mistaken. The PR attached where is the previous one I am working on.

Migrating the Notification system.

I can see the CustomToolbar.js as a class component in the master branch.

I am working on it and will raise a PR by today.

Can you confirm please? @leecalcote

@aabidsofi19 aabidsofi19 reopened this Aug 23, 2023
@leecalcote
Copy link
Member

@Rajdip019, oh, I assumed that the linked PR (merged) above was the fix for this issue.

@leecalcote
Copy link
Member

leecalcote commented Aug 23, 2023

I retract my comment about the good work being done here. 😉

…and will wait to lodge that comment after is is actually done. 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvement in current feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants