Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Setup Prettier #8661

Closed
nebula-aac opened this issue Sep 5, 2023 · 6 comments · Fixed by #8827
Closed

[UI] Setup Prettier #8661

nebula-aac opened this issue Sep 5, 2023 · 6 comments · Fixed by #8827
Assignees
Labels
component/ui User Interface framework/react kind/enhancement Improvement in current feature language/javascript Issues or pull requests that use Javascript or React

Comments

@nebula-aac
Copy link
Contributor

nebula-aac commented Sep 5, 2023

In Meshery UI, we do not use prettier, which means our code looks different throughout each files.

Even though we have Next.js lint for its linting capabilities, the linting job is not doing all what it is supposed to do with the current rules on certain formatting. However, for a true formatter, we're not using prettier, and it would be great to set one up here in Meshery UI and also setup pre-commit hook for this.

Here is what being used in Meshery Cloud, but it can be improved.

Please note that making this change will create a large PR. So it would be necessary to check through all the files that will be formatted, and probably won't need to be formatted.

The referenced file is at https://github.com/layer5io/meshery-cloud/blob/master/ui/.prettierrc.yml

arrowParens: avoid
tabWidth: 2
trailingComma: none
printWidth: 90

Contributor Guides and Handbook

@nebula-aac nebula-aac added kind/enhancement Improvement in current feature language/javascript Issues or pull requests that use Javascript or React component/ui User Interface framework/react labels Sep 5, 2023
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@dhiraj0911
Copy link
Contributor

Hey @nebula-aac, I'd like to work on this issue, can you assign this to me?

@Yana-Gupta
Copy link
Member

@nebula-aac I would like to work on this issue. Would you assign me.

@ShatilKhan
Copy link
Contributor

Hi @nebula-aac , I would like to understand this issue a bit more. What kind of changes are we looking for?
I have some front-end experience , if possible do assign this issue to me .

@aabidsofi19
Copy link
Contributor

+1 @nebula-aac

@arpitghura
Copy link

Hey, I would like to work on this issue. Can you please assign it to me? @nebula-aac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui User Interface framework/react kind/enhancement Improvement in current feature language/javascript Issues or pull requests that use Javascript or React
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants