Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Convert Header.js to Functional Component #8721

Open
10 tasks
nebula-aac opened this issue Sep 12, 2023 · 16 comments
Open
10 tasks

[UI] Convert Header.js to Functional Component #8721

nebula-aac opened this issue Sep 12, 2023 · 16 comments
Assignees
Labels
component/ui User Interface framework/react issue/remind Issue progress check issue/willfix This issue will be worked on kind/enhancement Improvement in current feature language/javascript Issues or pull requests that use Javascript or React

Comments

@nebula-aac
Copy link
Contributor

nebula-aac commented Sep 12, 2023

Original Issue: #7187

Tracking another issue for visibility: #8668

  • Move Header.js to its own directory
  • Break up Header.js and K8sContextMenu to its own exports
  • Remove unused file Headerstyle.js
  • React hooks and others using useEffect - setTransformProperty and handleKubernetesClick

Future items for tracking (not necessary to complete this ticket)

  • Identity the redux states
  • Identify useReducer potentials (to help with @reduxjs/toolkit migration later)
  • Identity the static styles
  • Identity the custom components - CustomChip, KubernetesIconButton and maybe TextField
  • Identity areas that can be refactored
  • Identity functions that can be moved to utils

Contributor Guides and Handbook

@nebula-aac nebula-aac added kind/enhancement Improvement in current feature language/javascript Issues or pull requests that use Javascript or React component/ui User Interface framework/react labels Sep 12, 2023
@nebula-aac nebula-aac self-assigned this Sep 12, 2023
@github-actions
Copy link

This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@ShatilKhan
Copy link
Contributor

Hi @nebula-aac, can I take this on?
I was working on ui/pages/index.js & ui/pages/settings.js & saw this one. I'm mostly done with the two files.
I can take this if you can assign me.

@nebula-aac
Copy link
Contributor Author

I'm working on this one, I already have this completed, just opened it for visibility and tracking

@ShatilKhan
Copy link
Contributor

Great! Thanks for the response!

@nebula-aac
Copy link
Contributor Author

Still working on this

@ShatilKhan
Copy link
Contributor

Let me know if you need any help

@nebula-aac
Copy link
Contributor Author

Still in progress, sorry. I was working on the design system and prettier config

@saurabh100ni saurabh100ni added the issue/remind Issue progress check label Nov 2, 2023
Copy link

github-actions bot commented Nov 2, 2023

Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

Copy link

stale bot commented Dec 16, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Dec 16, 2023
@nebula-aac
Copy link
Contributor Author

bump still working this, need to make sure that the toggle works correct in redux state

@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Dec 16, 2023
@iArchitSharma
Copy link
Contributor

@nebula-aac, hi! It's been a long time since you've been working on this issue. If you are not currently working on it, may I reassign it?

@nebula-aac
Copy link
Contributor Author

bump, revisiting to make sure that the state works as intended for this header

Copy link

stale bot commented Mar 19, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Mar 19, 2024
@vishalvivekm vishalvivekm added issue/willfix This issue will be worked on and removed issue/stale Issue has not had any activity for an extended period of time labels Apr 4, 2024
@nitin-pandita
Copy link

@nebula-aac are you still working on this issue ? I'm up for this issue

@iArchitSharma
Copy link
Contributor

@nitin-pandita you can start working on this

@nitin-pandita
Copy link

@nitin-pandita you can start working on this
Hi @iArchitSharma thank you for assigning this issue to me. Acutally I was just setting up the project and I was trying to run it locally and i couldn't find the package json file, there is the docker file, can you please guide be how to run the project locally. I

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui User Interface framework/react issue/remind Issue progress check issue/willfix This issue will be worked on kind/enhancement Improvement in current feature language/javascript Issues or pull requests that use Javascript or React
Projects
None yet
Development

No branches or pull requests

6 participants