Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Enhance dropdown menu that specifies docs version #9227

Open
coder12git opened this issue Oct 28, 2023 · 20 comments · May be fixed by #10795
Open

[Docs] Enhance dropdown menu that specifies docs version #9227

coder12git opened this issue Oct 28, 2023 · 20 comments · May be fixed by #10795
Assignees
Labels
area/docs Documentation update needed framework/jekyll good first issue Good for newcomers issue/willfix This issue will be worked on language/markdown Issues or pull requests that use Markdown

Comments

@coder12git
Copy link
Contributor

Current State

At present, there is an issue where the primary version button and its associated dropdown menu appear to be conflicting with each other, as depicted in the provided screenshot
Screenshot 2023-10-28 131512
Screenshot 2023-10-28 131526

Desired State

Add adequate spacing between primary version button and its associated dropdown menu -

Consider this as a reference -
Screenshot 2023-10-28 131404


Contributor Guides and Handbook

@coder12git coder12git added area/docs Documentation update needed language/markdown Issues or pull requests that use Markdown framework/jekyll good first issue Good for newcomers labels Oct 28, 2023
@aman44444
Copy link

@coder12git can i work on this issue ?

@coder12git
Copy link
Contributor Author

Go ahead @aman44444 🚀

@leecalcote
Copy link
Member

Cool!

@aman44444
Copy link

@coder12git I am unable to find the code file. Could you please provide me with a link to the file?

@coder12git
Copy link
Contributor Author

@coder12git I am unable to find the code file. Could you please provide me with a link to the file?

@aman44444 I apologize for the late response , check this file - https://github.com/meshery/meshery/blob/master/docs/_sass/navbar.scss

@coder12git
Copy link
Contributor Author

@aman44444 i am hoping that you will create a PR soon as it's just one line of css :)

@aman44444
Copy link

@coder12git sorry for the late response ,I've already attempted to modify that file, but it seems that the "select" class only applies to dropdown button not to dropdown options that is why i asked for file location.

@coder12git
Copy link
Contributor Author

coder12git commented Nov 2, 2023

@coder12git sorry for the late response ,I've already attempted to modify that file, but it seems that the "select" class only applies to dropdown button not to dropdown options that is why i asked for file location.

Yes, you are right, do one thing put that select inside a div and then style that div using "padding-bottom", i try that it works

@aman44444
Copy link

@coder12git ok, i will try tomorrow

@coder12git
Copy link
Contributor Author

@coder12git ok, i will try tomorrow

@aman44444 just updated my reply which i said earlier, please check that

@coder12git
Copy link
Contributor Author

coder12git commented Nov 2, 2023

@coder12git sorry for the late response ,I've already attempted to modify that file, but it seems that the "select" class only applies to dropdown button not to dropdown options that is why i asked for file location.

Yes, you are right, do one thing put that select inside a div and then style that div using "padding-bottom", i try that it works

Something like this -

<div style="padding-bottom: 5px">
<select>
</select>
</div>

@aman44444
Copy link

@coder12git we can't wrap select we have to wrap dropdown options , if your code is working make a PR

@Emmanuel-Sasere
Copy link

Emmanuel-Sasere commented Nov 18, 2023

Is it still available? @coder12git

@coder12git
Copy link
Contributor Author

Yes @Emmanuel-Sasere , assigning you 🚀

Copy link

stale bot commented Dec 30, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Dec 30, 2023
@saurabh100ni saurabh100ni added issue/willfix This issue will be worked on and removed issue/stale Issue has not had any activity for an extended period of time labels Jan 1, 2024
@sandramsc
Copy link
Member

This issue has been open for some time with no recent activity, unassigning to open it up for new contributors to give it a go.

@MonalikaPatnaik
Copy link
Contributor

Hi @coder12git can I take up this issue?

@Shreyask24
Copy link

Can I work on this?

@11happy
Copy link
Contributor

11happy commented Apr 15, 2024

Hello @sandramsc, @coder12git I am interested to work on this issue. Can you please assign this to me.

@11happy
Copy link
Contributor

11happy commented Apr 20, 2024

Hello , should I create a new custom dropdown? as we cant wrap the select.

@11happy 11happy linked a pull request Apr 26, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation update needed framework/jekyll good first issue Good for newcomers issue/willfix This issue will be worked on language/markdown Issues or pull requests that use Markdown
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants