New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI]: Push to Protected Branch without Pull Request #9932
Comments
Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Contributors' Welcome Guide, engage in the discussion forum, and be sure to join the community Slack. |
@RipulHandoo thanks for this. Is the workflow that you've mentioned failing? If not, please note that the point of the workflow is to automate necessary tasks for building and publishing an Edge release. Inserting manual review will break that automated process. The workflow and its actions are considered to be trusted and operating within the confines of its defined operating procedure. I could be missing something here, though. I wonder if this was a topic discussed on today's Meshery CI meeting and I'm missing context for the issue. |
Yes @leecalcote Sir this topic was discussed in today's Meshery CI meeting. @theBeginner86 asked me to raise an issue. So we can have a history/record of it. |
@RipulHandoo and anyone else interested, let's discuss options in in Layer5 discuss forum please: |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue. |
Current Behavior
Currently, the GitHub Actions workflow is attempting to push changes directly to the master branch, which is a protected branch in the repository. This results in a rejection due to the branch protection rules, which require changes to be made through a pull request.
Desired Behavior
The issue is to modify the GitHub Actions workflow to create a pull request instead of attempting to push changes directly to the protected master branch.
Implementation
Modify the GitHub Actions workflow to create a new branch, commit the changes to that branch, and then create a pull request to merge the changes into the master branch. This approach aligns with best practices for code review and ensures that changes go through the proper review process.
Contributor Guides and Handbook
The text was updated successfully, but these errors were encountered: