New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix Docs] Tutorial: Exploring Kubernetes CronJobs with Meshery Playground #10107
[Fix Docs] Tutorial: Exploring Kubernetes CronJobs with Meshery Playground #10107
Conversation
… - deploying a web app content without step 7 (deployment step) Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
🚀 Preview for commit 6e67bdb at: https://65b3ed90a4a5963d8bf862ba--meshery-docs-preview.netlify.app |
Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
🚀 Preview for commit c0aad55 at: https://65b44771f4e8de2d868c3402--meshery-docs-preview.netlify.app |
…ocess - section completed Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
🚀 Preview for commit a12d69f at: https://65b4f979b634208c0b35ab72--meshery-docs-preview.netlify.app |
🚀 Preview for commit 3eaf42d at: https://65c002d0d164b6a9f0beb12e--meshery-docs-preview.netlify.app |
🚀 Preview for commit 8dd5b52 at: https://65c6812a3c5c2f048c3df529--meshery-docs-preview.netlify.app |
Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
🚀 Preview for commit 36f7b77 at: https://65c7eabf637dc6aae2a4fec3--meshery-docs-preview.netlify.app |
Signal when ready for review. |
🚀 Preview for commit cd6e25f at: https://65d97aeac56064b943ba2c98--meshery-docs-preview.netlify.app |
Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
https://github.com/sandramsc/meshery into tutorial/sandramsc/9833
Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
@leecalcote |
Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
Hello @sandramsc I use a tool called Flameshot. https://flameshot.org/ |
Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
I haven't ran the steps myself yet, but here are my initial thoughts:
Good job @sandramsc, sorry if it's a lot of comments :), do change only what's really necessary and of priority |
Hi @sangramrath thanks for the feedback. Are you able to make inline comments, as it might be better to associate each point of feedback with the section referenced, also perhaps we can have a chat about these on next weeks website call. Also take note that the preview for the latest changes have not been generated, as you have probably already noticed. |
@sandramsc looks like I jumped the gun. Lee asked to check it out and I checked the last preview and left my comments. I will wait for the latest preview and leave inline comments. |
🚀 Preview for commit 222074c at: https://65e5faf70fc94e06a5684e97--meshery-docs-preview.netlify.app |
b0c8032
to
531ca30
Compare
…from feedback Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
Closed unintentionally while trying to merge updates from upstream - reopening. |
…l feedback Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
…netes-cronjobs.md Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
🚀 Preview for commit 745ff91 at: https://65f0bb27ef70043fd800b268--meshery-docs-preview.netlify.app |
@sandramsc is this ready for review? |
Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
🚀 Preview for commit 150b8bd at: https://6601750269f9eb1371ca795a--meshery-docs-preview.netlify.app |
@iArchitSharma, yes, I believe this is ready for review. |
🚀 Preview for commit 58eab07 at: https://660d2671e94936be0be38b6f--meshery-docs-preview.netlify.app |
Signed-off-by: Archit Sharma <74408634+iArchitSharma@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks @sandramsc
🚀 Preview for commit cd8bcca at: https://66226a3c0787aa07ced77c18--meshery-docs-preview.netlify.app |
This PR fixes #9833
Signed commits