New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create logic for screenshot capture in mesheryctl ref #5778
Conversation
Signed-off-by: Aadhitya A <aadhitya864@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #5778 +/- ##
=========================================
- Coverage 6.01% 5.97% -0.05%
=========================================
Files 107 107
Lines 9851 9924 +73
=========================================
Hits 593 593
- Misses 9101 9174 +73
Partials 157 157
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
if picLine != "" { | ||
buf.WriteString("## Screenshots\n\n") | ||
buf.WriteString(picLine) | ||
buf.WriteString("\n\n") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like an opportunity to capture a caption.
Example: "Display the list of all available applications."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, another line to be added then in the logic 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👨🎤
Signed-off-by: Aadhitya A <aadhitya864@gmail.com>
Signed-off-by: Aadhitya A <aadhitya864@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Thank you for today's example and demo, @alphaX86
Signed-off-by: Aadhitya A <aadhitya864@gmail.com>
I have added the pictures which @debo19 gave today... Almost added them in the code and in assets folder now |
🚀 Preview for commit 14ccd00 at: https://62d052146a2f0d009dc4bb43--meshery-docs-preview.netlify.app |
As I try to hunt down an example of what the screenshot looks like in the deployment preview, I notice that this command doesn't have a screenshot (but a tweet was previously sent, if memory serves correctly) - https://62d052146a2f0d009dc4bb43--meshery-docs-preview.netlify.app/reference/mesheryctl/app/onboard |
I see that you have each of these and more, but don't see them on the docs page. Please note that all of the screenshots should be pngs, not jpegs. |
Signed-off-by: Aadhitya A <aadhitya864@gmail.com>
🚀 Preview for commit 681e29f at: https://62d7f90938b2b84a6e2e18c1--meshery-docs-preview.netlify.app |
I don't seem to see the screenshots in the deployment preview... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the screenshots will show up after merge.
Signed-off-by: Aadhitya A aadhitya864@gmail.com
Description
This PR fixes #5776
Notes for Reviewers
Needs some links to test
Signed commits