Skip to content
This repository has been archived by the owner on Apr 16, 2023. It is now read-only.

Rename Route.url to Route.path #129

Open
meshy opened this issue Oct 25, 2017 · 0 comments
Open

Rename Route.url to Route.path #129

meshy opened this issue Oct 25, 2017 · 0 comments

Comments

@meshy
Copy link
Owner

meshy commented Oct 25, 2017

https://example.com/foo?bar
^^^^^^^^^^^^^^^^^^^^^^^^^^^ <- URL
^^^^^^^^                    <- protocol
        ^^^^^^^^^^^         <- hostname
                   ^^^^     <- path
                       ^^^^ <- query

What we're actually representing with the url field is actually a path. We should rename it.

Thanks to @ghickman for pointing this out, and for the ascii-art.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant