Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build file lacks install directives for shared object #6

Open
falconindy opened this issue Dec 5, 2018 · 1 comment
Open

build file lacks install directives for shared object #6

falconindy opened this issue Dec 5, 2018 · 1 comment

Comments

@falconindy
Copy link

In the default configuration, building fmt from the wrapped build produces a shared object which is never installed. This means projects using the wrap work within the build tree, but are broken upon installation.

From IRC:

14:05         jpakkane@ » No, just install it as normal.
14:05         dreisner  » i'm not sure what that means in this context.
14:06         dreisner  » i can't set install:true on the subproject's lib
14:06         jpakkane@ » Exactly the same thing as in any other context. It gets installed as usual.
                          If a subproject is missing install directives, then it is buggy and needs to be fixed.
14:07         dreisner  » so this is broken? https://github.com/mesonbuild/fmt/blob/5.2.1/meson.build
14:08         jpakkane@ » Yes. It's not installed at all so it won't work when built as a shared library.

There needs to be some detection of the shared lib being built to ensure that libfmt.so is installed.

@sarum9in
Copy link
Contributor

I think if you add install directive to https://github.com/mesonbuild/fmt/blob/5.2.1/meson.build it will solve the problem? Also possibly a conditional one if you prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants