Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pcap / CUPS versions not checked #2552

Closed
Salamandar opened this issue Oct 30, 2017 · 2 comments
Closed

Pcap / CUPS versions not checked #2552

Salamandar opened this issue Oct 30, 2017 · 2 comments

Comments

@Salamandar
Copy link
Contributor

Salamandar commented Oct 30, 2017

As of today, dependency('cups|pcap', version: ">=10000") does not fail.
The reason is that version_compare is called inside PkgConfigDependency.__init__(), but not inside {Cups,Pcap}Dependency.__init__().

Maybe a better solution would be to add a check_version(self) to the ExternalDependency that would do the job without having to repeat the same code in each specialized dependency.

@Salamandar
Copy link
Contributor Author

PR #2555 fixes that.

@nirbheek
Copy link
Member

Fixed with #2512.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants