Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

During cross compilation, base_options are being applied from native compiler class instead of cross compiler class #3628

Open
sompen opened this issue May 25, 2018 · 6 comments

Comments

@sompen
Copy link
Contributor

sompen commented May 25, 2018

It seems like the base_options are being applied from native compiler class only and the cross compiler's base_options are being ignored during cross compilation. Is this intended? What should be done to use the base_options of cross compiler only?

In interpreter.py:

`def add_languages(self, args, required):
..
..
self.add_base_options(comp)`

Thanks,
Sompen

@nirbheek
Copy link
Member

@xclaesse did this change with your PR to rework this code?

@xclaesse
Copy link
Member

xclaesse commented Jun 11, 2018

I think we always used native compiler base options. Even before my PR, add_languages() was already doing self.add_base_options(comp). I think this is the same type of issue than #3669, there is a massive confusion in meson about what apply to native or cross compiler.

@xclaesse
Copy link
Member

xclaesse commented Jun 27, 2018

As far as I understand it takes base options from the native compiler and use them for both native and cross compilers. Can it happen that they are from different class? Should we duplicate all base options so we can set different values for native and cross compilers? like b_asneeded and b_native_asneeded, etc... ?

If we got that path, I guess we should also have c_args and c_native_args etc...

@Ericson2314
Copy link
Member

Can we test this again? I wouldn't be surprised if it is fixed. If it is not #4010 should fix it.

@Ericson2314
Copy link
Member

Can somebody write a test? I'll take care of fixing things so the test passes.

@marc-h38
Copy link
Contributor

Can somebody write a test? I'll take care of fixing things so the test passes.

Would something like #6362 work ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants