-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meson configuration of DXVK winelib build, with CC / CXX environment variables prepended, works for 64-bit build, but fails for 32-bit build. Without, the inverse happens. #5246
Comments
Sounds like this is further fallout from #5102. |
Might be related, but it seems slightly different, being a little more severe. At least it was possible to override the cross-compilation being ignored, and I recall being able to build it in the past, so this particular issue is caused by a newer commit. I'll look into doing some bisection. |
After a bit more thorough testing, I discovered that the 64-bit build fails without prepending Conversely, the 32-bit build works without prepending the variables, but not with it. |
Curious bug. |
Sounds like #5102 to me. |
Ah, that makes sense now. Sounds like a complicated issue, from what I've been reading so far. |
Should I close this, then? |
Let's keep it open and we can verify that it's fixed. |
Fixed with #5234 and verified. |
This issue still persists for me, even with that pull request. :( |
@Ericson2314 could you look at this too? Seems like it's not fixed by #5234 |
Yep, it works. What are the plans for the master branch? |
#4010 would fix it better in my opinion. |
I have been getting this issue with meson 0.54.0. Is it still not fixed? This breaks the DXVK build in Debian repositories. Is there a patch that we could apply to Debian's meson in the meantime? |
I am sorry this has been such an issue, and wasn't just automatically fixed as I had hoped.
The last "general env var cleanup" commit of mine you might try applying is #6827 . [I just rebased it so it will apply to 0.54 and master cleanly.] Do experiment with that, but I can't in good faith say just apply it Debian wide if it does help, as @jpakkane and I disagreed on whether the change is good and I don't want to circumvent his authority. If that patch doesn't fix it---and at this point I am thinking that is likely----we'll need more details to get to the bottom of what's going wrong here. |
Quick update: My build system does not allow for easy testing of your patch, but I intend to do this as soon as I have the time. Thank you for your quick response, I'll try to do my part in helping you debug this. If the patch does not work, you can probably reproduce by getting a Debian machine and building dxvk in it. If you cannot access a Debian machine, please let me know and the Debian Project can give you remote access to one trough this process (I would sponsor the request). I'll report back. |
Please note that, at this point, it is very highly recommended to build DXVK with Mingw instead, as Winelib builds had all sorts of weird issues. Mingw is the officially-approved build method, also, I think. |
Terminal output:
https://invent.kde.org/snippets/145
Meson log for DXVK build.32
The text was updated successfully, but these errors were encountered: