You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The boost dependency allows the user to specify a boost specific include dir. Builds fail since these includes are not treated as a "system" include.
/usr/lib64/boost169 exists, but the dependency fails to find the boost libraries in there, because it's a bunch of .so symlinks to files in /usr/lib64.
Compiling against boost as installed this way uses -I for the include dirs, spurring a bunch of warnings as errors.
I can use "include_type = 'system'" when declaring the boost dependency, but it seems like this should always be done and every boost dependency usage shouldn't need to specify this.
This works, although I'm not sure it's the "proper" way to achieve this default:
diff --git a/mesonbuild/dependencies/boost.py b/mesonbuild/dependencies/boost.py
index 8fb258e..88b9347 100644
--- a/mesonbuild/dependencies/boost.py
+++ b/mesonbuild/dependencies/boost.py
@@ -347,6 +347,8 @@ class BoostDependency(ExternalDependency):
assert isinstance(buildtype, str)
self.debug = buildtype.startswith('debug')
self.multithreading = kwargs.get('threading', 'multi') == 'multi'
+ # Always treat boost includes as system includes
+ self.include_type = 'system'
self.boost_root = None # type: T.Optional[Path]
self.explicit_static = 'static' in kwargs
Thoughts?
The text was updated successfully, but these errors were encountered:
Describe the bug
The boost dependency allows the user to specify a boost specific include dir. Builds fail since these includes are not treated as a "system" include.
To Reproduce
Expected behavior
Custom boost include directories should always be treated as system dirs
system parameters
Where:
/usr/lib64/boost169 exists, but the dependency fails to find the boost libraries in there, because it's a bunch of .so symlinks to files in /usr/lib64.
Compiling against boost as installed this way uses
-I
for the include dirs, spurring a bunch of warnings as errors.I can use "include_type = 'system'" when declaring the boost dependency, but it seems like this should always be done and every boost dependency usage shouldn't need to specify this.
This works, although I'm not sure it's the "proper" way to achieve this default:
Thoughts?
The text was updated successfully, but these errors were encountered: