Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_target failure post 0.57.0 #8927

Closed
tolnaisz opened this issue Jun 23, 2021 · 1 comment
Closed

run_target failure post 0.57.0 #8927

tolnaisz opened this issue Jun 23, 2021 · 1 comment

Comments

@tolnaisz
Copy link

With release version 0.57.0 and later the previous functionality of run_target has changed without a release note mention and causes setup issues.

In our setup we have a few run_target:s which execute additional checks/packaging steps. Not all are necessary to be executed when building (like packaging) the sources. The extra steps are executing some command-line tool like CppCheck.

Pre-0.57.0 we were able to have a run_target in our meson.build files even on machines where the command-line tool wasn't present (some developer machines). Of course it wasn't possible to "build" those targets on those machines but that wasn't even a problem as those were not meant to be done anyway and are not built by default.

Post-0.57.0 this isn't possible anymore. The setup fails on machines without all the tools with an error saying that the tool isn't found. This check isn't necessary and the previous functionality was correct. The target should be only created and it should fail only when "built".

The issue was introduced by the be86199 commit (Fix run_targets running scripts from different subdirs.).

@eli-schwartz
Copy link
Member

Duplicate of #8641

@eli-schwartz eli-schwartz marked this as a duplicate of #8641 Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants