Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic way of passing docker parameters #536

Closed
strzelecki-maciek opened this issue Aug 26, 2015 · 3 comments
Closed

Generic way of passing docker parameters #536

strzelecki-maciek opened this issue Aug 26, 2015 · 3 comments
Milestone

Comments

@strzelecki-maciek
Copy link

On top of #484 , wouldnt it be better if You copied the way Marathon is handling docker parameters passing?

This gives much more flexibility into passing parameters, especially:

 "parameters": [
            { "key": "a-docker-option", "value": "xxx" },
            { "key": "b-docker-option", "value": "yyy" }
        ]

taken from: https://mesosphere.github.io/marathon/docs/rest-api.html#post-v2-apps

"container": {
"type": "DOCKER",
"docker": {
"image": "group/image",
"network": "BRIDGE",
"portMappings": [
{
"containerPort": 8080,
"hostPort": 0,
"servicePort": 9000,
"protocol": "tcp"
},
{
"containerPort": 161,
"hostPort": 0,
"protocol": "udp"
}
],
"privileged": false,
"parameters": [
{ "key": "a-docker-option", "value": "xxx" },
{ "key": "b-docker-option", "value": "yyy" }
]
},
"volumes": [
{
"containerPath": "/etc/a",
"hostPath": "/var/data/a",
"mode": "RO"
},
{
"containerPath": "/etc/b",
"hostPath": "/var/data/b",
"mode": "RW"
}
]
},

@bobrik
Copy link
Contributor

bobrik commented Sep 1, 2015

+1 for this feature, logging could benefit from this.

@yanglei99
Copy link

I would also like the support of passing "env" to Docker containers as what Marathon does today. e.g.
"env": {
"LD_LIBRARY_PATH": "/usr/local/lib/myLib"
},

@strzelecki-maciek
Copy link
Author

closing, as Feature/docker params #538 was merged

@mwasn mwasn added this to the 2.5.0 milestone Dec 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants