Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the issue when backends on overlay are not removed when the agent dies #93

Merged
merged 1 commit into from Apr 13, 2017

Conversation

GoelDeepak
Copy link

@GoelDeepak GoelDeepak commented Mar 17, 2017

Note: This commit depends on the new key-value format in lashup.
If you are planning to upgrade minuteman then please first
transition to previous commit (which has the transition code)
and then move to this commit.


This change is Reviewable

@GoelDeepak GoelDeepak changed the title Fixes the issue when backends on overlay are not removed the agent dies Fixes the issue when backends on overlay are not removed when the agent dies Mar 17, 2017
@codecov-io
Copy link

codecov-io commented Mar 17, 2017

Codecov Report

Merging #93 into master will decrease coverage by 1.1%.
The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   73.96%   72.86%   -1.11%     
==========================================
  Files          12       12              
  Lines         945      903      -42     
==========================================
- Hits          699      658      -41     
+ Misses        246      245       -1
Impacted Files Coverage Δ
src/minuteman_lb_mgr.erl 28.57% <100%> (ø) ⬆️
src/minuteman_lashup_vip_listener.erl 86.28% <100%> (ø) ⬆️
src/minuteman_mesos_poller.erl 86.97% <92%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 157f003...ff707a2. Read the comment docs.

Note: This commit depends on the new key-value format in lashup.
If you are planning to upgrade minuteman then please first
transition to previous commit (which has the transition code)
and then move to this commit.
@asridharan
Copy link

@GoelDeepak do we need a version of this for 1.8.9?

@GoelDeepak
Copy link
Author

@asridharan we cannot fix it in 1.8.x

@GoelDeepak GoelDeepak merged commit 185970e into master Apr 13, 2017
@GoelDeepak GoelDeepak deleted the fix-DCOS-13919 branch April 13, 2017 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants