Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning about DC/OS nodes requirement #19

Closed
rimusz opened this issue Oct 1, 2017 · 6 comments
Closed

Warning about DC/OS nodes requirement #19

rimusz opened this issue Oct 1, 2017 · 6 comments
Assignees

Comments

@rimusz
Copy link
Contributor

rimusz commented Oct 1, 2017

read me should have a warning about 6 monsters nodes will be created.
got puzzled for a while as docker deploy failed with missing VMs, then double checked that GCS compute instance group was trying to created 6 instances, my account needed quote increase.

@hectorj2f
Copy link

👋 @rimusz Thanks for reporting this issue! Yeah, we probably need to add some additional links to these sentence in the README Google Cloud (GCE) credentials (AWS and Azure are supported as well) with the necessary permissions

@rimusz
Copy link
Contributor Author

rimusz commented Oct 2, 2017

maybe also to have an option to set lover spec VMs, as current ones are very beefy ones.
or point the user where to change VMs type:
https://github.com/mesosphere/dcos-kubernetes-quickstart/blob/master/Makefile#L83
https://github.com/mesosphere/dcos-kubernetes-quickstart/blob/master/Makefile#L116

@pires
Copy link
Contributor

pires commented Oct 3, 2017

@spahl @smugcloud I think that we should remove the automation (Makefile) if we can't support it. At this time, I don't think we can and it seems to be causing a negative impact.

@hectorj2f
Copy link

@pires @spahl We could easily improve this user experience by extracting the yaml files with the vm definitions out of the Makefile.

A quick solution could be to move the yaml templates out of the Makefile and simply refer them in the Makefile by LAUNCH_CONFIG_GCE=cat $(./resources/gce.template.yaml)`. With this solution, it'd be more clear to users to see which target infrastructure we support, as well as to facilitate its customization. I can send a PR if you agree about it.

@hectorj2f
Copy link

We've extracted the yaml files out of the Makefile into the resources directory (https://github.com/mesosphere/dcos-kubernetes-quickstart/tree/master/resources). We also added a note in the README.md to allow users to customize them.

I think we can close this issue.

@rimusz
Copy link
Contributor Author

rimusz commented Oct 17, 2017

cool

@rimusz rimusz closed this as completed Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants