-
Notifications
You must be signed in to change notification settings - Fork 846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the API for URIs #1377
Comments
Could we also check any downloaded URI against a SHA1 or MD5 that gets included in the json config? |
I like your suggestions, @abhay-agarwal and @ConnorDoyle. If I understood @bernd-mesos correctly, the meson-fetcher supports setting permissions. It does not support checksums. So for the check sums we would need further support in mesos-fetcher. |
I'd love to see this! There's also fetcher configuration to avoid extracting tar.gz files if you don't want it extracted automatically. Perhaps something like; {
"urls": {
"hdfs:///utils/my-thing": {
"extract": true,
"executable": true
}
}
} Making this a dict would allow for easier backwards compatibility, too. |
Once the Fetcher Cache MVP is committed (hopefully next week), checksums are on my plate in the next sprint. |
That's awesome to hear @bernd-mesos! I think the structure I posted above would work well with this as it'd be as simple as adding |
Blocked by #1505, as we'd probably want to experiment with this for the v3 REST API.
|
Don't we have fetch for this now? |
In Mesos, command URIs can have some additional data, like whether to attempt to extract the downloaded file, and whether the downloaded file should have the executable permission bit set. The Marathon API doesn't adequately model these options, leading to awkward workarounds. (e.g.
chmod ug+x myfile.sh && ./myfile.sh
)The text was updated successfully, but these errors were encountered: