Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the API for URIs #1377

Closed
ConnorDoyle opened this issue Apr 9, 2015 · 7 comments
Closed

Fix the API for URIs #1377

ConnorDoyle opened this issue Apr 9, 2015 · 7 comments

Comments

@ConnorDoyle
Copy link
Contributor

In Mesos, command URIs can have some additional data, like whether to attempt to extract the downloaded file, and whether the downloaded file should have the executable permission bit set. The Marathon API doesn't adequately model these options, leading to awkward workarounds. (e.g. chmod ug+x myfile.sh && ./myfile.sh)

@ConnorDoyle ConnorDoyle added this to the 0.9.0 milestone Apr 9, 2015
@abhay-agarwal
Copy link

Could we also check any downloaded URI against a SHA1 or MD5 that gets included in the json config?

@kolloch
Copy link
Contributor

kolloch commented Apr 13, 2015

I like your suggestions, @abhay-agarwal and @ConnorDoyle.

If I understood @bernd-mesos correctly, the meson-fetcher supports setting permissions. It does not support checksums. So for the check sums we would need further support in mesos-fetcher.

@kolloch kolloch modified the milestones: 0.9.0, 0.10.0 May 18, 2015
@tarnfeld
Copy link

I'd love to see this! There's also fetcher configuration to avoid extracting tar.gz files if you don't want it extracted automatically. Perhaps something like;

{
  "urls": {
    "hdfs:///utils/my-thing": {
      "extract": true,
      "executable": true
    }
  }
}

Making this a dict would allow for easier backwards compatibility, too.

@bernd-mesos
Copy link
Contributor

Once the Fetcher Cache MVP is committed (hopefully next week), checksums are on my plate in the next sprint.

@tarnfeld
Copy link

That's awesome to hear @bernd-mesos! I think the structure I posted above would work well with this as it'd be as simple as adding checksum field.

@ConnorDoyle
Copy link
Contributor Author

Blocked by #1505, as we'd probably want to experiment with this for the v3 REST API.

On May 29, 2015, at 06:01, Tom Arnfeld notifications@github.com wrote:

That's awesome to hear @bernd-mesos! I think the structure I posted above would work well with this as it'd be as simple as adding checksum field.


Reply to this email directly or view it on GitHub.

@jasongilanfarr
Copy link
Contributor

Don't we have fetch for this now?

@mesosphere mesosphere locked and limited conversation to collaborators Mar 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants