Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better JSDoc with @example #45

Open
Tracked by #68
mesqueeb opened this issue May 31, 2023 · 4 comments
Open
Tracked by #68

Better JSDoc with @example #45

mesqueeb opened this issue May 31, 2023 · 4 comments
Labels

Comments

@mesqueeb
Copy link
Owner

mesqueeb commented May 31, 2023

Note that right now "is-what" is terrible for Google SEO since even refinements like "is-what npm" or "is-what github" all are like "What is GitHub?" and "What is npm? A quick intro." instead of this package. 馃ぃ I think that a website would be a good idea to make a presence for Googlers and also provide valuable documentation overview that is generated from code and doesn't need to be custom-made in the readme. Specifically, examples are CRUCIAL.

open question: will this ticket cover improving the SEO?

@mesqueeb mesqueeb mentioned this issue May 31, 2023
5 tasks
@jcbhmr
Copy link
Collaborator

jcbhmr commented May 31, 2023

I am not sure if examples will improve SEO. I honestly have no idea. I just know that right now I get this kind of results:

image

My best guess is that having a website wit the title matching "is-what" is the best thing. The examples just give Google more content and "fullness" to flesh out the webpages themselves so that GoogleBot doesn't think "empty website, not important" and instead thinks "full website, good ranking"

@jcbhmr
Copy link
Collaborator

jcbhmr commented May 31, 2023

btw something I noticed: I don't think you need to duplicate JSDoc and TS type annotations 馃

/**
 * Returns the object type of the given payload
 *
 * @param {*} payload
 * @returns {string}
 */
export function getType(payload: any): string {
  return Object.prototype.toString.call(payload).slice(8, -1)
}

can just be 馃憞

/**
 * Returns the object type of the given payload
 */
export function getType(payload: any): string {
  return Object.prototype.toString.call(payload).slice(8, -1)
}

@jcbhmr
Copy link
Collaborator

jcbhmr commented Jun 3, 2023

This is the kind of lackluster docs I'm talking about when I say "we should improve the docs" 馃槩
image

@jcbhmr jcbhmr changed the title add more extensive JSDoc blocks with @example Better JSDoc with @example Jun 3, 2023
@jcbhmr
Copy link
Collaborator

jcbhmr commented Jun 3, 2023

I've come around to believe that having more content (i.e. examples) would also help improve SEO. Right now here's what it looks like on Google: https://www.google.com/search?q=is-what+site%3Agithub.io

image

@jcbhmr jcbhmr mentioned this issue Jun 3, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants