New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metacontroller only considers the most recent QA values for reconfiguration #31

Open

chcorbato opened this issue May 20, 2020 · 0 comments

Assignees

Labels

question

Contributor

chcorbato commented May 20, 2020 •

edited

Loading

The QAs values are received asynchronously:
https://github.com/rosin-project/mros1_reasoner/blob/0a8022676b597f59fb8b6880f3d05955628f8643/mros1_reasoner/scripts/mros1_reasoner.py#L128

but the reasoner to decide if an adaptation is needed is executed sync
https://github.com/rosin-project/mros1_reasoner/blob/0a8022676b597f59fb8b6880f3d05955628f8643/mros1_reasoner/scripts/mros1_reasoner.py#L193

As a result, I think that we are not considering some QA values for reconfiguration.

Do we need to reduce increase the metacontrol freq?
- see https://github.com/rosin-project/mros1_reasoner/blob/b6d0a836f96ea8e85353b11ef5d4d6dd0e589dc8/mros1_reasoner/scripts/mros1_reasoner.py#L325
Shall we do it? How much?
- Reasoner needs over 1 sec for each loop see Metacontrol loop takes around 1 sec? #38

We need to confirm if this is a problem and then decide what to do.

chcorbato added the help wanted label

chcorbato self-assigned this

chcorbato added question and removed help wanted labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment