Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with pandas. pandas.DataFrame.append was deprecated #100

Closed
tiagofrepereira2012 opened this issue May 1, 2023 · 0 comments · Fixed by #101
Closed

Error with pandas. pandas.DataFrame.append was deprecated #100

tiagofrepereira2012 opened this issue May 1, 2023 · 0 comments · Fixed by #101

Comments

@tiagofrepereira2012
Copy link
Contributor

tiagofrepereira2012 commented May 1, 2023

Hi, the following tests are falling

FAILED tests/pipeline/test_pipeline_highlevel.py::TestGetPPGSQIs::test_on_get_ppg_sqis - AttributeError: 'DataFrame' object has no attribute 'append'. Did you mean: '_append'?
FAILED tests/pipeline/test_pipeline_highlevel.py::TestGetQualifiedPPG::test_on_get_qualified_ppg - AttributeError: 'DataFrame' object has no attribute 'append'. Did you mean: '_append'?
FAILED tests/pipeline/test_pipeline_highlevel.py::TestGetECGSQIs::test_on_get_ecg_sqis - AttributeError: 'DataFrame' object has no attribute 'append'. Did you mean: '_append'?
FAILED tests/pipeline/test_pipeline_highlevel.py::TestGetQualifiedSQIs::test_on_get_qualified_ecg - AttributeError: 'DataFrame' object has no attribute 'append'. Did you mean: '_append'?

The thing is that pandas.DataFrame.append used here https://github.com/meta00/vital_sqi/blob/main/vital_sqi/pipeline/pipeline_functions.py#L476, was deprecated a long time ago. Check here pandas-dev/pandas#35407 and here pandas-dev/pandas#44539

pandas.DataFrame.concat should be used instead.

I will push a fix shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant