Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the Eclipse LWB plugin and then building a language project causes build errors #39

Closed
Gohla opened this issue Sep 7, 2021 · 2 comments
Labels
C-Bug Category: bug. Not working as expected

Comments

@Gohla
Copy link
Member

Gohla commented Sep 7, 2021

Summary

Updating the Eclipse LWB plugin and then building a language project causes unexpected/weird build errors.

What you did

Update the Eclipse LWB plugin to a newer version, and then build the language project.

What you expected to happen

Building to succeed.

What actually happened

Building fails with a PIE exception, such as hidden dependencies, overlapping provided files, etc.

Context

  • Spoofax version: Any
  • Operating system & version: Any

Additional information

Updating Spoofax may change the equals/hashCode of certain objects, which may influence the build and make it go wrong. It can also happen that deserializing an older serialized state may cause wierd errors.

@Gohla Gohla added the C-Bug Category: bug. Not working as expected label Sep 7, 2021
@Gohla Gohla added the P-High Priority: high. Should take priority over low and non-prioritized label Oct 21, 2021
@Gohla Gohla removed the P-High Priority: high. Should take priority over low and non-prioritized label Nov 9, 2021
@Gohla
Copy link
Member Author

Gohla commented May 9, 2022

This could be fixed by adding code to SpoofaxDynamicLoadingEclipseParticipant#getPieModuleCustomizer that stores/loads the Spoofax version and does not deserialize when the version has changed.

@Gohla
Copy link
Member Author

Gohla commented May 9, 2022

Fixed for release versions in 3fd637e. Not fixed for the development version, but that is not something that users should use anyway.

@Gohla Gohla closed this as completed May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Bug Category: bug. Not working as expected
Projects
None yet
Development

No branches or pull requests

1 participant