Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDF3 files in subdirectories can cause the parenthesizer file to not import the correct signatures, causing build errors #61

Closed
Gohla opened this issue Sep 21, 2021 · 1 comment
Labels
C-Bug Category: bug. Not working as expected P-High Priority: high. Should take priority over low and non-prioritized

Comments

@Gohla
Copy link
Member

Gohla commented Sep 21, 2021

Summary

SDF3 files in subdirectories can cause the parenthesizer file to not import the correct signatures, causing build errors.

What you did

Put syntax in subdirectories and build the language project.

What you expected to happen

Building to succeed.

What actually happened

Build fails with errors in in the generated parenthesizer file.

Context

  • Spoofax version: 0.11.11
  • Operating system & version: Any

Additional information

Commit from student that reproduces the problem: https://gitlab.ewi.tudelft.nl/CS4200/2021-2022/student-njkyu/-/commit/44d4d4f09f161a5702dbc17afdce8db7625468de

@Gohla Gohla added C-Bug Category: bug. Not working as expected P-High Priority: high. Should take priority over low and non-prioritized labels Sep 21, 2021
@Gohla
Copy link
Member Author

Gohla commented Sep 23, 2021

Fixed by metaborg/sdf@1c9e255 and f2012a6, to be released in the next release.

@Gohla Gohla closed this as completed Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Bug Category: bug. Not working as expected P-High Priority: high. Should take priority over low and non-prioritized
Projects
None yet
Development

No branches or pull requests

1 participant