Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs type names are getting displayed by runners name, It should be displayName instead. #69

Closed
Creatoon opened this issue Jul 1, 2022 · 1 comment

Comments

@Creatoon
Copy link
Collaborator

Creatoon commented Jul 1, 2022

Suggested solution.

File to refer -> https://github.com/metacall/protocol/blob/master/src/language.ts

{
		tag: 'node',
		displayName: 'NodeJS',
		hexColor: '#3c873a',
		fileExtRegex: /^js$/,
		runnerName: 'nodejs',
		runnerFilesRegexes: [/^package\.json$/]
}

Should use displayName instead of runnerName.

@Creatoon
Copy link
Collaborator Author

Creatoon commented Jul 4, 2022

fixed by commit 2a6f5a5

@Creatoon Creatoon closed this as completed Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant