Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[slack] invoke apps.uninstall if installation fails after successful authorization #102

Open
gigxz opened this issue Jul 22, 2021 · 2 comments
Open

[slack] invoke apps.uninstall if installation fails after successful authorization #102

gigxz opened this issue Jul 22, 2021 · 2 comments
Labels
component: plugin New plugin request, or feature request on an existing plugin priority: low low priority

Comments

@gigxz
Copy link
Collaborator

gigxz commented Jul 22, 2021 •
edited
Loading

This issue refers to this code comment. The installation process requires the installer to be an admin, because PolicyKit requires it. We're only able to check if the installing user is an admin after they perform the install, at which point the app is already installed from Slack's point of view. As you can see in the linked code, we raise an error if the installing user is not an admin, or if we fail to get their user info. At that point we should also uninstall the app using apps.uninstall because we are failing the installation.
@gigxz gigxz added the component: plugin New plugin request, or feature request on an existing plugin label Jul 22, 2021
@shaunagm
Copy link
Collaborator

shaunagm commented Dec 2, 2021

Can you provide a little more detail, @mashton? Thank you!

@shaunagm shaunagm added the triage label Dec 7, 2021
@gigxz
Copy link
Collaborator Author

gigxz commented Dec 20, 2021

Related policykit/policykit#509

@gigxz gigxz changed the title Slack: revoke token when authorization fails [slack] invoke apps.uninstall if installation fails after successful authorization Dec 27, 2021
@shaunagm shaunagm added priority: low low priority and removed triage labels Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: plugin New plugin request, or feature request on an existing plugin priority: low low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shaunagm @gigxz