Add x.ss.iter{keys,values,items}
#201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've been sitting on this for a while, so I thought I'd push this up. I still need to read the documentation more closely. Also, SuiteSparse:GraphBLAS provides even more iteration functionality.
|
Alright, I think this is finished and ready for review. This doesn't expose row iterators and column iterators for matrices, but I'm not really sure what those would be good for. So, I think it's fine to punt for now. |
jim22k
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been sitting on this for a while, so I thought I'd push this up.
I still need to read the documentation more closely. Also,
SuiteSparse:GraphBLAS provides even more iteration functionality.
This should make
x.ss.iso_valueeven faster, which can speed up PageRank 馃帀 . Speaking of, this changes the return type ofx.ss.iso_valuefromScalarto a Python scalar. Meh.