Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complex monoid UDFs are finally working! #210

Merged
merged 2 commits into from Apr 14, 2022

Conversation

eriknw
Copy link
Member

@eriknw eriknw commented Apr 14, 2022

Update to latest python-suitesparse-graphblas to avoid segfaults 🤞 .
Also, let's see if using pytest-randomly works now.

Update to latest python-suitesparse-graphblas to avoid segfaults.
Also, let's see if using `pytest-randomly` works now.
@eriknw eriknw closed this Apr 14, 2022
@eriknw eriknw reopened this Apr 14, 2022
@eriknw
Copy link
Member Author

eriknw commented Apr 14, 2022

I ran two sets of CI tests with pytest-randomly, and everything passed! I think we may have more-or-less fixed the segfaults. The complex monoid segfault has been known for a couple of years, and it feels really good to finally get it fixed. The solution still seems super-weird to me 🤷‍♂️

I deleted pytest-randomly for now. May add later. Seems like a pretty good trick for testing robustness.

Everybody should update to python-suitesparse-graphblas 7.0.3.1!

@eriknw eriknw merged commit 563b9f1 into python-graphblas:main Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant