Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More consistent examples #42

Closed
cesarcosta99 opened this issue Oct 11, 2016 · 2 comments
Closed

More consistent examples #42

cesarcosta99 opened this issue Oct 11, 2016 · 2 comments

Comments

@cesarcosta99
Copy link
Contributor

I've noticed you kept ES5 syntax in some given examples, e.g. functions instead of arrow functions. Was it on purpose? If it wasn't, I would be happy to contribute and rework the examples.
@metagrover
Copy link
Owner

Hi @cesarcosta99, thanks for bringing this into my attention. I guess, the functions in the Promises section can be rewritten as arrow functions. Feel free to modify and send in a PR.

Do let me know, if you feel there are more changes that can be done regarding this issue.

@cesarcosta99 cesarcosta99 mentioned this issue Oct 12, 2016
Merged
@cesarcosta99
Copy link
Contributor Author

Hi @metagrover, no problem, I sent the PR. Please tell me if has something you disagree. BTW great repo, I'm happy to contribute to it 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@metagrover @cesarcosta99