Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement admin as Plugin #22

Closed
majst01 opened this issue Jun 16, 2023 · 6 comments
Closed

Implement admin as Plugin #22

majst01 opened this issue Jun 16, 2023 · 6 comments

Comments

@majst01
Copy link
Contributor

majst01 commented Jun 16, 2023

can be done with: spf13/cobra#691

@simcod
Copy link
Contributor

simcod commented Jun 20, 2023

Is this a time-critical task? If not, I could have a look at it:)

@majst01
Copy link
Contributor Author

majst01 commented Jun 20, 2023

Is this a time-critical task? If not, I could have a look at it:)

I try to create a POC soon

@simcod
Copy link
Contributor

simcod commented Jun 22, 2023

Is this a time-critical task? If not, I could have a look at it:)

I try to create a POC soon

All right. Let me know if I can support you.

@majst01
Copy link
Contributor Author

majst01 commented Jul 1, 2023

OK made created a new repo: https://github.com/metal-stack-cloud/admin-plugin and integrated that in this PR: #21

If we all find this useful i would like to force-push a fresh content to this repo and make it public

@majst01
Copy link
Contributor Author

majst01 commented Nov 5, 2023

Should be possible again with cobra v1.8.0 released yesterday: spf13/cobra#2018

@Gerrit91
Copy link
Contributor

We decided not to implement the admin CLI as a plugin for now because it was introducing too much complexity. This admin commands are now in-tree but the command is not shown in the help texts or the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants