ClayCards #196
ClayCards #196
Conversation
…t must always appear if image exists. User Card doesn't accept icons.
|
Just started reviewing :) |
Sent from 
There was a problem hiding this comment.
Separating the markings by some components would be ideal or would it be the most elegant way to do it than many if terms? since we can share lots of markups, like the image, folder variants...
You could check the indentation on the soy, some are inconsistent. Just to organize.
| * Content Renderer name of card. | ||
| * @instance | ||
| * @memberof ClayCard | ||
| * @type {?array|undefined} |
There was a problem hiding this comment.
SF: Should be {?array}.
| * Flag to indicate if the card is disabled or not. | ||
| * @instance | ||
| * @memberof ClayCard | ||
| * @type {?bool|undefined} |
There was a problem hiding this comment.
SF: Should be {?bool}.
| * Flag to indicate if the card is selectable or not. | ||
| * @instance | ||
| * @memberof ClayCard | ||
| * @type {?bool|undefined} |
There was a problem hiding this comment.
SF: Should be {?bool}.
| * Flag to indicate if the card is selected or not. | ||
| * @instance | ||
| * @memberof ClayCard | ||
| * @type {?bool|undefined} |
There was a problem hiding this comment.
SF: Should be {?bool}.
| * The path to the SVG spritemap file containing the icons. | ||
| * @instance | ||
| * @memberof ClayCard | ||
| * @type {!string} |
There was a problem hiding this comment.
SF: Should be ?string|undefined. Since the soy is used optionally.
| * Flag to indicate if the card is selectable or not. | ||
| * @instance | ||
| * @memberof ClayUserCard | ||
| * @type {?bool|undefined} |
There was a problem hiding this comment.
SF: Should be {?bool}.
| * Flag to indicate if the card is selected or not. | ||
| * @instance | ||
| * @memberof ClayUserCard | ||
| * @type {?bool|undefined} |
There was a problem hiding this comment.
SF: Should be {?bool}.
| * The path to the SVG spritemap file containing the icons. | ||
| * @instance | ||
| * @memberof ClayUserCard | ||
| * @type {!string} |
There was a problem hiding this comment.
Maybe we can leave ?String|undefined since it is not used icon in some cases. What do you think?
| * Url to be applied to the title of the card. | ||
| * @instance | ||
| * @memberof ClayUserCard | ||
| * @type {?string} |
There was a problem hiding this comment.
SF: Should be {?string|undefined}.
| /** | ||
| * Metal ClayHorizontalCard component. | ||
| */ | ||
| class ClayHorizontalCard extends Component {} |
There was a problem hiding this comment.
It would not be better ClayFolderCard since this component is intended for this use case, could generate some confusion. What do you think?
|
Hey @matuzalemsteles could you please do the SF (based on https://github.com/google/closure-compiler/wiki/Annotating-JavaScript-for-the-Closure-Compiler) and resent? Thx! |
|
Resent here #201. |
No description provided.