This repository has been archived by the owner on Jan 16, 2018. It is now read-only.
Create ClayTable #217
Closed
Create ClayTable #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just started reviewing :) |
Sent from 
matuzalemsteles
force-pushed
the
clay-table
branch
from
c34ee52
to
2f9b669
Compare
|
Just started reviewing :) |
|
Resent #222 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer
This is an implementation of the lexicon table pattern, I am not sure if we will implement with this component the definition of inline edit table or we will only separate into another component and if it will be more feasible for the experience of using the component.
Missing features
API
The API tries to follow the definition of Lexicon, how to use just the
Stickerbefore the first column, Also having to leave the custom table to supply all the use cases like addingcolspanto athand adding custom classes intdandth.I'm not sure about the
useEllipseAPI name that adds an ellipse when the text overflows its size.Columns drag and drop
I've been talking to @pat270 in the last few days about how d&d would be implemented in columns of the tables, Patrick even prepared a visual test and how to proceed, but we've been wondering if this is performed and will generate many bugs, so we decided to work with this functionality more cautiously and implement it in the best possible way.