This repository has been archived by the owner on Jan 16, 2018. It is now read-only.
Create ClayTable #228
Merged
Create ClayTable #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 29 commits
December 22, 2017 15:30
… with a flag in the API.
packages/clay-table/package.json
Outdated
| "metal" | ||
| ], | ||
| "dependencies": { | ||
| "clay-button": "1.0.0-alpha.8", |
There was a problem hiding this comment.
hey @carloslancha, Upgrade to the latest versions of Clay to not have some problems in compiling and jest.
There was a problem hiding this comment.
Thx @matuzalemsteles I didn't realize versions changed while developing the component ;)
|
Just started reviewing :) |
Sent from
packages/clay-table/src/ClayTable.js
Outdated
| class ClayTable extends Component { | ||
| /** | ||
| * @inheritDoc | ||
| * Handles document click in order to hide menu. * Handles document click in order to hide menu. */ |
|
Awesome working @carloslancha. Merged, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developed with clay#develop
Missing features: