This repository has been archived by the owner on Jan 16, 2018. It is now read-only.
EnableMcritic #235
Merged
EnableMcritic #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbalsas
previously requested changes
Dec 27, 2017
There was a problem hiding this comment.
Hey @carloslancha, I'm not sure these are the right changes, we should have different regex settings so we can target the current code without the need of rewriting the imports as named imports and disabling eslint for them...
jbalsas
dismissed
their stale review
All clear, changes make sense when explained! 👍
jbalsas
reviewed
Dec 27, 2017
packages/clay-card/src/ClayCard.js
Outdated
| @@ -1,12 +1,15 @@ | |||
| /* eslint-disable */ | |||
| import { ClayActionsDropdown } from 'clay-dropdown'; | |||
| /* eslint-disable */ | |||
There was a problem hiding this comment.
This should probably be enable 😉
jbalsas
reviewed
Dec 27, 2017
| @@ -1,11 +1,14 @@ | |||
| /* eslint-disable */ | |||
| import { ClayActionsDropdown } from 'clay-dropdown'; | |||
| /* eslint-disable */ | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #204