-
Notifications
You must be signed in to change notification settings - Fork 14
Update ClayTable, ClayList and ClayCardGrid schemas. Add plus button as a dropdown feature to Management Toolbar #254
Update ClayTable, ClayList and ClayCardGrid schemas. Add plus button as a dropdown feature to Management Toolbar #254
Conversation
Just started reviewing :) |
…and emit events on deselect click and action item click in ClayManagementToolbar
Just started reviewing :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @carloslancha, realizes that when we open the dropdown for the first time the separator
is rendered and after we close and open again it disappears, this happens with more than 1 separator
and only when not using groups.
Notice that the separator
value comes undefined
in ClayDropdownItem not respecting its default value when it is not passed.
I'll have to update the examples again at claycss.com 😅
}, | ||
{ | ||
href: '#2', | ||
label: 'Option 2', | ||
label: 'Download', | ||
separator: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just remove the separator
since it is not necessary anymore in the demo. 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added another element so now the separator makes sense.
@@ -49,29 +53,33 @@ | |||
*/ | |||
{template .item} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this template being used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've refactored all this stuff
@matuzalemsteles nice catch! FYI: It was a bug caused by the creation of |
No description provided.