Skip to content
This repository has been archived by the owner on Jan 16, 2018. It is now read-only.

Update ClayTable, ClayList and ClayCardGrid schemas. Add plus button as a dropdown feature to Management Toolbar #254

Merged
merged 16 commits into from
Jan 11, 2018
Merged

Update ClayTable, ClayList and ClayCardGrid schemas. Add plus button as a dropdown feature to Management Toolbar #254

merged 16 commits into from
Jan 11, 2018

Conversation

carloslancha
Copy link
Collaborator

No description provided.

@matuzalemsteles
Copy link
Collaborator

Just started reviewing :)

:octocat: Sent from GH.

@carloslancha carloslancha changed the title Update ClayTable, ClayList and ClayCardGrid demos Update ClayTable, ClayList and ClayCardGrid schemas. Add plus button as a dropdown feature to Management Toolbar Jan 10, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.3%) to 81.026% when pulling a05cbf2 on carloslancha:ClayManagementToolbar.features.2 into 2722611 on metal:master.

@matuzalemsteles
Copy link
Collaborator

Just started reviewing :)

:octocat: Sent from GH.

Copy link
Collaborator

@matuzalemsteles matuzalemsteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @carloslancha, realizes that when we open the dropdown for the first time the separator is rendered and after we close and open again it disappears, this happens with more than 1 separator and only when not using groups.

Notice that the separator value comes undefined in ClayDropdownItem not respecting its default value when it is not passed.

I'll have to update the examples again at claycss.com 😅

q1f2gjljno

},
{
href: '#2',
label: 'Option 2',
label: 'Download',
separator: true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove the separator since it is not necessary anymore in the demo. 🙂

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added another element so now the separator makes sense.

@@ -49,29 +53,33 @@
*/
{template .item}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this template being used?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've refactored all this stuff

@carloslancha
Copy link
Collaborator Author

@matuzalemsteles nice catch!

FYI: It was a bug caused by the creation of ClayDropdownItem component. I didn't realize that component was rendering, in some cases like in the separator true one, more than one element, and each complete component (the output of the .render template) can only render one element, all nodes after that are ignored.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.05%) to 81.279% when pulling a437985 on carloslancha:ClayManagementToolbar.features.2 into 2722611 on metal:master.

@jbalsas jbalsas merged commit 75c99c1 into deprecate:master Jan 11, 2018
@carloslancha carloslancha deleted the ClayManagementToolbar.features.2 branch January 13, 2018 15:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants