Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing HTML entity unescaping test in HTML2IncDom #415

Open
mbrukman opened this issue Jul 16, 2020 · 0 comments
Open

Failing HTML entity unescaping test in HTML2IncDom #415

mbrukman opened this issue Jul 16, 2020 · 0 comments

Comments

@mbrukman
Copy link

In a recent build which just changes the base Ubuntu OS image used by Travis, and a required change from Oracle JDK 8 → OpenJDK 8, we see the following failure:

Chrome 84.0.4147 (Windows 7 0.0.0) HTML2IncDom should unescape html entities inside element attributes FAILED
	AssertionError: expected '<form action="actionurl?foo=&quot;&lt;2&quot;&amp;bar=&gt;bar"></form>' to equal '<form action="actionurl?foo=&quot;<2&quot;&amp;bar=>bar"></form>'
	    at Function.assert.strictEqual (node_modules/chai/chai.js:2329:32)
	    at Context.<anonymous> (/tmp/packages/metal-incremental-dom/test/html/HTML2IncDom.js:48:10)

I'm not sure what the correct expected behavior here is, so it's unclear what needs to be fixed. It appears that &lt; and &gt; were expected to be changed to < and >, respectively, but appears that's not happening, and unclear if that's due to a more recent version of Chrome or something else changing in the environment, as the last successful build in this repo was over a year ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant