Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky go-e2e-dns on Go 1.20 Linux #1206

Closed
aviramha opened this issue Mar 22, 2023 · 8 comments · Fixed by #1207
Closed

Flaky go-e2e-dns on Go 1.20 Linux #1206

aviramha opened this issue Mar 22, 2023 · 8 comments · Fixed by #1207
Assignees
Labels
bug Something isn't working CI flaky-test

Comments

@aviramha
Copy link
Member

Seems that some sort of a deadlock/timeout is happening in this test.
https://github.com/metalbear-co/mirrord/actions/runs/4483891847
https://github.com/metalbear-co/mirrord/actions/runs/4483668126

@aviramha
Copy link
Member Author

One of the issues here is that the test hangs forever, so another thing we need to do is to add timeouts.
I am adding timeout to the test but have created la10736/rstest#190 so we can cover all tests.

@meowjesty
Copy link
Member

Looks like this fix wasn't enough, as we still get flaky behavior (CI run).

@meowjesty meowjesty reopened this Mar 23, 2023
@eyalb181 eyalb181 added bug Something isn't working CI labels Mar 31, 2023
@t4lz t4lz self-assigned this Apr 2, 2023
@t4lz
Copy link
Member

t4lz commented Apr 3, 2023

Looks like this fix wasn't enough, as we still get flaky behavior (CI run).

So far I can't reproduce this timeout flake, but there is an occasional go crash. That crash looks like it might be related to issue #380.

@aviramha
Copy link
Member Author

aviramha commented Apr 4, 2023

I think it's the same - just for some reason in the e2e it doesn't detect the crash and waits for it forever

@t4lz
Copy link
Member

t4lz commented Apr 4, 2023

in the e2e it doesn't detect the crash and waits for it forever

Also the go crash I sent is in the E2E test.

@aviramha
Copy link
Member Author

aviramha commented Apr 4, 2023

I know

@eyalb181 eyalb181 assigned Razz4780 and unassigned t4lz Aug 13, 2023
@aviramha
Copy link
Member Author

I'm not sure if this had stopped happening or we disabled the test?

@Razz4780
Copy link
Contributor

The test is enabled, has not failed in the last couple days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI flaky-test
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants